test(signals): fix drifted queue-health fixture dates (unblocks main CI) - #1003
Merged
Conversation
The shared signals-v2 pull-request fixture used fixed updatedAt dates. PR #10 ('2026-05-23') crossed the 30-day likely-reviewable cutoff as real time advanced, so 'adds queue age buckets and likely-reviewable counts' began failing (likelyReviewable 0, expected >= 1) — breaking test shard 2 + the validate aggregator on main and every open PR. Anchor the fixture ages relative to now so the windows never drift.
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 110 110
Lines 15079 15079
Branches 5451 5451
=======================================
Hits 14569 14569
Misses 106 106
Partials 404 404 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ghost
added
the
gittensor:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test (2)+ thevalidateaggregator are failing on main and on every open PR (#985, #996, #997). Root cause is a single time-bomb test:The shared
pullRequestsfixture used fixedupdatedAtdates. PR #10 (2026-05-23) was chosen to be "recent" but, as of 2026-06-22, it is exactly 30 days old — crossing the< 30 dayslikely-reviewable cutoff inbuildQueueHealth, solikelyReviewablePullRequestsdropped to 0.Fix
Anchor the shared fixture's PR ages relative to now (
isoDaysAgo(20)/isoDaysAgo(82)) so the age-bucket / reviewability windows never drift again. Test-only change; all 31 tests in the file pass.This unblocks
test (2)+validatefor main and the three open PRs.